Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

Toolbar is not showing up #189

Closed
agentdalecoper opened this issue Jun 21, 2020 · 4 comments
Closed

Toolbar is not showing up #189

agentdalecoper opened this issue Jun 21, 2020 · 4 comments

Comments

@agentdalecoper
Copy link

Hi guys, node editor is a super cool framework!
Have the issue that the toolbar is not showing up in the node editor. Maybe doing something wrong.
So cannot assign my custom canvas there.
Everything else seems to work nicely.
Using Unity 2020.2.0a10

image
agentdalecoper added a commit to agentdalecoper/Node_Editor_Framework that referenced this issue Jun 21, 2020
@agentdalecoper
Seneral#189 Fix toolbar not showing up.
3aaa602
@agentdalecoper
Copy link
Author

Created PR with assumption how to fix it.

agentdalecoper added a commit to agentdalecoper/Node_Editor_Framework that referenced this issue Jun 21, 2020
@agentdalecoper
Seneral#189 Better fix to support older unity versions.
e260f62
@agentdalecoper
Copy link
Author

The second commit is more correct.

@Seneral
Copy link
Owner

Seneral commented Jun 21, 2020

Hey, thanks for reporting and even fixing it.
So they changed it that quickly again, got to like that. Will have to take a look what's up with editor scaling in the newer version, and how it works now. Can't imagine they simply removed it.

@Seneral
Copy link
Owner

Seneral commented Jun 22, 2020

Ok took a look at it and it seems I just didn't implement it properly.
The name of CustomEditorUIScale should have given it away - if you don't explicitly set your editor scale, this editorprefs entry will not be created. And if you disable it again (use system standard) it will go to max value to indicate it should not be used.
However since this is only the custom scale, if the system standard is used and it is not 100%, it will still not work, and afaik there is no reliable way to get that.
So I just rewrote it a bit to not need the editor scale in the first place - always best.

Seneral added a commit that referenced this issue Jun 22, 2020
@Seneral
LTS v1.0.3 UI fixes
768b0e6 
Fixed #189 toolbar not showing up introduced in f82311c (v1.0.3)
Improved GUISkin handling so that the default GUIStyle are always used
	- Fixes some problems with missing styles at Runtime if not explicitly set, as well as issues when switching between dark and light modes
	- New behaviour: Always generate DefaultSkin and save to file for user to copy and modify. If OverriddenSkin.asset exists, use that style as a basis instead.
Fixed issue with XML IO for objects that can not be serialized (e.g. Texture2D in TextureCompose example)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Seneral @agentdalecoper