Skip to content
This repository has been archived by the owner on May 11, 2020. It is now read-only.

Update game.lua #26

Merged
merged 2 commits into from
Sep 20, 2019
Merged

Update game.lua #26

merged 2 commits into from
Sep 20, 2019

Conversation

kaborja
Copy link
Contributor

@kaborja kaborja commented Sep 18, 2019

potential fixes:

  • tips now state that $5000 is required for owning a company, instead of $10
  • only one digit is shown after a decimal point for the amount of money in profile
  • !p command isn't extremely case-sensitive now

potential fixes:
- tips now state that $5000 is required for owning a company, instead of $10
- only one digit is shown after a decimal point for the amount of money in profile
- !p command isn't extremely case-sensitive now
game.lua Outdated Show resolved Hide resolved
@Seniru
Copy link
Owner

Seniru commented Sep 18, 2019

Thanks for contributing! I'll test the code and tell my decision.

game.lua Outdated Show resolved Hide resolved
game.lua Show resolved Hide resolved
game.lua Outdated Show resolved Hide resolved
Copy link
Owner

@Seniru Seniru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most changes are OK! I've requested some changes in comments. Please view them and make the changes.
And thanks again for contributing for this project 😄

@Seniru
Copy link
Owner

Seniru commented Sep 18, 2019

@all-contributors please add @kaborja for code

@allcontributors
Copy link
Contributor

@Seniru

I've put up a pull request to add @kaborja! 🎉

@Seniru
Copy link
Owner

Seniru commented Sep 18, 2019

I've reopened issues #23 #24 #25 and planned to close them after merging this PR. (You can add commits named 'closes #23, #24, #25) to close them automatically

- fixed stuff involving float/formatNumber
- replaced "Atelie801" with "Atelier801"
- added a new line for the text area with "Lessons left"
Copy link
Owner

@Seniru Seniru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get ready! This will be merged after testing

table.insert(jobs, Job("Junior miner", 25, 0.1, 3, nil, "shaman", "Atelie801"))
table.insert(jobs, Job("Cheese producer", 50, 0.15, 7, nil, "shaman", "Atelie801"))
table.insert(jobs, Job("Cheese miner", 250, 0.2, 10, "Cheese mining", "shaman", "Atelie801"))
table.insert(jobs, Job("Cheese collector", 10, 0.05, 1, nil, "shaman", "Atelier801"))
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't think why did I typed atelie everywhere 😆
Thanks for fixing

@Seniru
Copy link
Owner

Seniru commented Sep 20, 2019

Approved

@Seniru Seniru merged commit 66b7922 into Seniru:master Sep 20, 2019
@Seniru
Copy link
Owner

Seniru commented Sep 20, 2019

Congratulations and Thanks for the pull request 😄 🎆 🎆

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants