Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to remove basics from card pool #430

Closed
Senryoku opened this issue Apr 24, 2023 · 5 comments
Closed

Option to remove basics from card pool #430

Senryoku opened this issue Apr 24, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@Senryoku
Copy link
Owner

In some game mode (e.g. Housman, Solomon...), keeping basics when drafting from standard sets doesn't make a lot of sense and feels bad when drafting. They are automatically omitted when possible, but not when the set has some other possible lands in its land slot.

Add an option (enabled by default?) in their respective dialog to remove basics from the card pool after it has been generated. Generate more packs (by reducing their expected size by one) to make sure we generate enough cards.

@Senryoku Senryoku added the enhancement New feature or request label Apr 24, 2023
@NerdyNathan
Copy link
Contributor

@Senryoku are you taking contributions? I think I could work on this. Thanks for all the great work!

@Senryoku
Copy link
Owner Author

Senryoku commented May 1, 2023

@Senryoku are you taking contributions? I think I could work on this. Thanks for all the great work!

I do, thanks for asking!
In this case I merely opened this issue as a note to myself because I couldn't tackle it immediately. It shouldn't take me too long to implement once I have time to work on it, but feel free to look around if you're interested :)

@NerdyNathan
Copy link
Contributor

Sounds good, I'll poke around

@NerdyNathan
Copy link
Contributor

I think I've got it working locally for Solomon draft. For which draft modes did you want this option? I expect at least these:

  • Solomon
  • Winston
  • Winchester
  • Housman
  • Grid

@Senryoku
Copy link
Owner Author

Senryoku commented May 2, 2023

I don't have a list, but yours looks good!

Senryoku added a commit that referenced this issue May 3, 2023
Option to remove basics from card pool (#430) - Initial implementation with Solomon Draft. Extended to Housman, Winchester, and Winston draft.

---------

Co-authored-by: Nathan Fleming <nfleming@natera.com>
Co-authored-by: Senryoku <maretverdant@gmail.com>
@Senryoku Senryoku closed this as completed May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants