Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to remove basics from card pool #455

Merged
merged 7 commits into from
May 3, 2023
Merged

Option to remove basics from card pool #455

merged 7 commits into from
May 3, 2023

Conversation

NerdyNathan
Copy link
Contributor

No description provided.

@NerdyNathan NerdyNathan changed the title Option to remove basics from card pool #430 Option to remove basics from card pool May 3, 2023
@NerdyNathan
Copy link
Contributor Author

Pull request for #430

@Senryoku
Copy link
Owner

Senryoku commented May 3, 2023

Looks good, thank you very much!
Now that I see it, I realize that this doesn't make much sense for GridDraft since we generate packs of an expected known size there.
I think I'll also factor the removeBasics call out of generateBoosters, this function is already pretty complicated and removeBasics should be called in all branches, I think it make sense to have the start* functions handle that directly.
I'll add these changes to this branch, hope that's ok!

@NerdyNathan
Copy link
Contributor Author

Yup, sounds good, I think that was my initial idea to call it in each start* method, but figured we could just call it upfront when generating the boosters. 😁
Re: the complexity of generateBoosters, I saw a couple places to clean it up that will hopefully improve readability. I'll open another pull request and you can see if you agree!

@Senryoku Senryoku merged commit 881a9ad into Senryoku:master May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants