Docviewer stlye revamp #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov Report
@@ Coverage Diff @@
## develop #658 +/- ##
===========================================
+ Coverage 91.92% 92.02% +0.10%
===========================================
Files 212 212
Lines 5647 5646 -1
Branches 1415 1415
===========================================
+ Hits 5191 5196 +5
+ Misses 456 450 -6
Continue to review full report at Codecov.
|
added 2 commits
April 30, 2020 21:33
zoltanbedi
approved these changes
May 4, 2020
packages/sn-document-viewer-react/src/components/document-widgets/ToggleThumbnails.tsx
Outdated
Show resolved
Hide resolved
herflis
approved these changes
May 4, 2020
…ets/ToggleThumbnails.tsx Co-authored-by: Zoltán Bedi <zoltan.bedi@gmail.com>
taki9
reviewed
May 4, 2020
packages/sn-document-viewer-react/src/components/document-widgets/ToggleThumbnails.tsx
Outdated
Show resolved
Hide resolved
added 3 commits
May 4, 2020 13:03
taki9
approved these changes
May 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When opening a document the command palette's icon in the header becomes black
The docviewer's header should be the same color as the sidebar with no shadow
The icons color should be the same as the sidebar icons, when active the color should be #26A69A
The comment icon is too far away from the close button
When the comments are opened the add comment link should be under the title
The cancel button should be outlined Screen Shot 2020-04-23 at 14.48.14.png -> should be white/black without outlined style
Question: Is there a need for multiple rotate functions (there are two separate right now) and multiple resizing tools?
Yes. One is for the page and one is for the document
+1: Approve dialog button style change
