Skip to content
This repository has been archived by the owner on Jun 30, 2022. It is now read-only.

Use a safe query in PageTemplateManager to load pages. #28

Merged
merged 1 commit into from
Sep 10, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/WebPages/PageTemplateManager.cs
Original file line number Diff line number Diff line change
Expand Up @@ -311,8 +311,7 @@ private IEnumerable<Node> LoadPageList()
{
if (SearchManager.ContentQueryIsAllowed)
{
var cql = $"+TypeIs:{typeof(Page).Name} + PageTemplateNode:{_pageTemplate.Id}";
return ContentQuery.Query(cql, QuerySettings.AdminSettings).Nodes;
return ContentQuery.Query(SafeQueries.LoadPagesForTemplate, QuerySettings.AdminSettings, _pageTemplate.Id).Nodes;
}
// we need to execute a direct database query because the outer engine is disabled
return NodeQuery.QueryNodesByReferenceAndType("PageTemplateNode", this.PageTemplateNode.Id, ActiveSchema.NodeTypes[typeof(Page).Name], false).Nodes;
Expand Down
3 changes: 3 additions & 0 deletions src/WebPages/SafeQueries.cs
Original file line number Diff line number Diff line change
Expand Up @@ -21,5 +21,8 @@ public class SafeQueries : ISafeQueryHolder

/// <summary>Returns with the following query: "+TypeIs:@0 +SmartUrl:@1 -Path:@2"</summary>
public static string SmartUrlCollision { get; } = "+TypeIs:@0 +SmartUrl:@1 -Path:@2";

/// <summary>Returns the following query: "+TypeIs:Page +PageTemplateNode:@0"</summary>
public static string LoadPagesForTemplate { get; } = "+TypeIs:Page +PageTemplateNode:@0";
}
}