SHDLC: Separate error value for too long frames #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnestler
reviewed
Jan 22, 2020
rnestler
approved these changes
Jan 23, 2020
While an added error value may be considered a breaking change, I wouldn't call it breaking, since we make no guarantee about it. |
abrauchli
force-pushed
the
separately-handle-frame-too-long-error
branch
from
5f11941
to
c312ab0
Compare
abrauchli
changed the title
done |
Better error handling when decoding incorrect SHDLC frames: * Add a new error constant `SENSIRION_SHDLC_ERR_FRAME_TOO_LONG` which is returned when the frame contains more data than expected (the length field) * When a CRC is supplied, it is now checked before checking if the frame is too long, causing the exit path (CRC error) to be backtraceable.
abrauchli
force-pushed
the
separately-handle-frame-too-long-error
branch
from
c312ab0
to
d599ad1
Compare
rnestler
approved these changes
Jan 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better error handling when decoding incorrect SHDLC frames:
SENSIRION_SHDLC_ERR_FRAME_TOO_LONGwhichis returned when the frame contains more data than expected (the
length field)
frame is too long, causing the exit path (CRC error) to be
backtraceable.
Check the following:
make style-fix)