Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Again: Tab content and titles disrupted #1797

Closed
martinstoehr opened this issue Jul 25, 2023 · 18 comments · Fixed by #1988
Closed

Again: Tab content and titles disrupted #1797

martinstoehr opened this issue Jul 25, 2023 · 18 comments · Fixed by #1988
Labels
Bug Something isn't working

Comments

@martinstoehr
Copy link

  • Sequel Ace Version (including build number): 4.0.6 (20048)
  • Sequel Ace Source (App Store/GitHub/Homebrew): App Store
  • macOS Version: 13.5
  • Processor Type (Intel/Apple): Apple
  • MySQL Version: all
  • macOS Localization: en, de

With the latest version all the serious errors from the past are here again...

Please have a look at this: #1056

In addition Sequel Ace locks up when having more than two tabs open with ssh-connection and closing one of them.

@HJCunha
Copy link

HJCunha commented Jul 26, 2023

I'm seeing this issue happening too. It was there in the past, got solved at some point but now is back and is annoyingly dangerous as we believe we are editing one server but we can be changing a different one..

@anthonyvdg-se
Copy link

anthonyvdg-se commented Aug 2, 2023

Seems to happen often when creating new tabs while there are other active tabs, especially when creating new tabs while the active tab is not the last.

@xixi773
Copy link

xixi773 commented Aug 10, 2023

Hello,

I can confirm the issue with:

  • Sequel Ace Version (including build number): 4.0.7 (20050)
  • Sequel Ace Source (App Store/GitHub/Homebrew): App Store
  • macOS Version: 13.4
  • Processor Type (Intel/Apple): Intel
  • MySQL Version: all
  • macOS Localization: en

@ArneAmeye
Copy link

I'm experiencing this too lately, on 4.0.6 I started noticing this, upgraded to 4.0.7 version and still seeing this bug.
Tabs get mixed up all the time, it's dangerous if you don't pay attention to it since you might be editing or export/import data that you did not expect to work with.

@cl2714
Copy link

cl2714 commented Aug 17, 2023

Can you fix this bug as soon as possible? It's really too dangerous

@dlt-
Copy link

dlt- commented Aug 17, 2023

Same here. Happens with Mysql/mariadb connection tabs too. Shows another database tables/content (which is not even open anymore in any visible tab)

Sequel Ace Version (including build number): 4.0.7 (20050)
Sequel Ace Source (App Store/GitHub/Homebrew): App Store
macOS Version: 14.0beta
Processor Type (Intel/Apple): Apple
MySQL Version: all
macOS Localization: en

@stevierayrobison
Copy link

Same issue. Dangerous. Window title correct. Tab title incorrect.
Screenshot 2023-08-23 at 4 44 54 PM

Sequel Ace Version (including build number): 4.0.7 (20050)
Sequel Ace Source (App Store/GitHub/Homebrew): App Store
macOS Version: Ventura 13.4.1
Processor Type (Intel/Apple): Apple
MySQL Version: all (AWS RDS)
macOS Localization: en

@Jason-Morcos
Copy link
Member

I am able to reproduce this but I can't figure out how to fix it. I'm hopeful that @Kaspik may be able to find a fix, but in the interim I encourage you to only open new tabs when the last tab is active. If anyone else out there is able to fix this, I would gladly review that PR.
The simple steps to reproduce are to open a new tab when the active tab isn't the last tab in the tab bar.

@Jason-Morcos Jason-Morcos added the Bug Something isn't working label Sep 4, 2023
@martinstoehr
Copy link
Author

You can use version 4.0.5, this is working correct in that case.

@somegooser
Copy link

Can this update be released as a new version? Im using the latest version (4.0.13) downloaded via Mac App store and the bug is still active. I almost deleted a table in the production server.. Dangerous bug like this.

@Jason-Morcos
Copy link
Member

Can this update be released as a new version? Im using the latest version (4.0.13) downloaded via Mac App store and the bug is still active. I almost deleted a table in the production server.. Dangerous bug like this.

Hey @somegooser - if someone can find the bug and propose a fix, I'd be super happy to review that PR and merge and release. So far, as far as I'm aware nobody's been able to identify the cause of the bug to fix it.

@somegooser
Copy link

Hi,

I dont know how to fix this bug but i know the way to reproduce the bug all the time.

The problem appears when you pres the 'plus' sign to add a new tab while not being active on the last tab.

So example if you have 3 tabs open and currently active on the second tab. If you press add new tab the connection will be added to the LAST tab while the last tab is already a working connection.

But if the third (last tab in this example) is active and you press add new tab it will work just fine.

This bug can easily be fixed if the new tab ALWAYS gets added as last.

@Mike-LA-UK
Copy link

Not sure about it being related to the plus button or if that's just a good way to replicate it. For me it basically seems that if I have three tabs open, let my mac sleep overnight, come back in the morning then there's a decent chance that the 2nd and 3rd tab have now swapped and will mismatch to what the actual database is.

It's super dangerous as far as bugs go for a database management client (I know everyone has said that, but it really is!).

Hadn't spotted it before because I used to use a different client for prod to dev/etc - will go back to that for safety. Hope someone can work out the cause as it's a fantastic client otherwise!

@dgm
Copy link

dgm commented Mar 22, 2024

It bugged on my simply dragging the last tab over to reorder; the last two tabs became the same database as the original last tab, and I could not access what had been the next to last tab.

@Kaspik
Copy link
Member

Kaspik commented Apr 2, 2024

The only thing that changed between 4.0.5 and 4.0.6 and could be related is this PR: #1736 - although I'm not sure how it could.

Hopefully found a fix and open a PR: #1988

TLDR - hard to believe but opening a new tab via "+" vs opening it via CMD+T differs from system standpoint.
In case user hits "+" in the UI in tab bar - system automatically creates a tab for us and adds it to the tabGroup - there is no way to avoid it and no way to work around it - and it adds it where it wants and doesn't care about the order. We do care about order but system just puts the tab to different place.

From now on, these two actions will differ a little - when user hits "+" in the UI, it will create a new tab always at the end of the tab bar list. If user hits "CMD+T" (or similar action in menu), it will create tab following the currently active tab.

@somegooser
Copy link

@Jason-Morcos hi jason did you see this pull request? and could it fix this problem?

@Kaspik
Copy link
Member

Kaspik commented Apr 11, 2024

Jason is enjoying a two week holiday and will take care of it over the weekend once he gets back :)

@Jason-Morcos
Copy link
Member

Sorry for the delay, thank you, @Kaspik! New Release Candidate pushed to GitHub now

https://github.com/Sequel-Ace/Sequel-Ace/releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.