-
-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warning should be shown when Keychain cannot be used due to Cleartext plugin being enabled #285
Comments
Can you provide more detail as to what the issue is as you are experiencing it? When do you expect a password to be saved and it's not being saved? |
Steps to recreate:
I noticed that there are NO entries in my keychain for passwords for Sequel Ace (though there were for Sequel Pro) |
This is a very strange issue. I definitely cannot reproduce. |
Hm.. can this be relevant? Sequel-Ace/Source/SPKeychain.m Lines 47 to 52 in 7a71505
|
Yes, looks like the possible source of trouble. I tried with this env var set and lost Keychain access: % LIBMYSQL_ENABLE_CLEARTEXT_PLUGIN=1 /Applications/Sequel\ Ace.app/Contents/MacOS/Sequel\ Ace
2020-08-14 01:19:31.277 Sequel Ace[44057:10824358] Failed to set (systemColorOfName) user defined inspected property on (SPButtonBar): [<SPButtonBar 0x7f85b5e35070> setValue:forUndefinedKey:]: this class is not key value coding-compliant for the key systemColorOfName.
2020-08-14 01:19:31.497 Sequel Ace[44057:10824358] LIBMYSQL_ENABLE_CLEARTEXT_PLUGIN is set. Disabling keychain access. See Issue #2437 @wrmoon what your output of the console command |
@stychos That's the culprit alright! When I launch SA from a terminal window, passwords are saved correctly. When I launch from spotlight search (cmd-space) it doesn't work. I opened SA from the spotlight search, and checked the environment variables ( |
I think it maybe hidden in your .bash_profile, .zshrc or in mysqld launcher. Try to verify that places. |
But now I wonder why keychain access is disabled when the cleartext plugin is enabled. Couldn't the password be intercepted even if the password isn't stored in the keychain? |
Sorry, I can't answer you this question. You can try to read related issues in Sequel Pro tracker to have more vision: sequelpro/sequelpro#2437 and sequelpro/sequelpro#2247 |
At the very least, it might be good if we popped up a one-time alert indicating to the user that keychain cannot be used because MySQL clear text is enabled? It is confusing that the end user can't tell what's going on! |
Thought about that too. Maybe we need to change the issue title and/or description appropriately and keep this open for a while? |
In case someone has the same issue and reads this thread, I fixed my problem by moving |
I'm gonna close this for now, as we haven't seen any other issues really and it's solved afaik. :) |
Passwords are not getting saved at all. No entries in keychain for Sequel Ace.
Sequel Ace version 2.1.5
MacOs 10.15.5 (19F101)
MacBook Pro (15-inch, 2019)
Would appreciate any suggestions to help debug this
The text was updated successfully, but these errors were encountered: