Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Favorite Query Variables Display in Black Always in SPTextView #382

Closed
Jason-Morcos opened this issue Oct 2, 2020 · 2 comments · Fixed by #520
Closed

Favorite Query Variables Display in Black Always in SPTextView #382

Jason-Morcos opened this issue Oct 2, 2020 · 2 comments · Fixed by #520
Labels
Bug Something isn't working

Comments

@Jason-Morcos
Copy link
Member

Jason-Morcos commented Oct 2, 2020 •
edited

  • Sequel Ace Version: 2.2.0
  • macOS Version: 10.15

Description
Variables such as those inserted by the Sequel Ace query favorites are always displayed in black text, making them basically invisible in dark query editor themes. I thought it might be something about the doSyntaxHighlighting method of SPTextView, but for the life of me I can't figure this out!

Steps To Reproduce

  1. Set theme to "Dark Ace" or another dark background query editor theme
  2. Paste the following string into the query editor (do not run query) SELECT example of issue ${1:default_value} see

Expected Behaviour
Black is not a text color for anything in the Dark Ace theme, so the text should not display in black.

Is Issue Present in Latest Beta?
yes

Additional Context

Screen Shot 2020-10-01 at 23 29 01
@Jason-Morcos Jason-Morcos added Bug Something isn't working Help wanted Extra attention is needed PR Welcome Issues and fixes available for wide community to help us move forward by creating a PR with solution labels Oct 2, 2020
@luzannew luzannew mentioned this issue Nov 14, 2020
Merged
@Jason-Morcos Jason-Morcos added Fixed & Pending Release and removed Help wanted Extra attention is needed PR Welcome Issues and fixes available for wide community to help us move forward by creating a PR with solution labels Nov 14, 2020
@Jason-Morcos Jason-Morcos mentioned this issue Nov 14, 2020
Merged
@Jason-Morcos
Copy link
Member Author

Leaving open until the fix is actually released. Somehow this got auto-closed :|

@Jason-Morcos Jason-Morcos reopened this Nov 14, 2020
Jason-Morcos added a commit that referenced this issue Nov 14, 2020
@Jason-Morcos
Merge branch 'main' into main-3_0_0
ddda185 
* main:
  Fixed #382 Updated lexfile to fix the color theme issue for the snippet parsing ${1:name}
@Kaspik Kaspik closed this as completed in 7ef618f Nov 16, 2020
@Jason-Morcos
Copy link
Member Author

Reopening until released

@Jason-Morcos Jason-Morcos reopened this Nov 16, 2020
@Jason-Morcos Jason-Morcos mentioned this issue Nov 19, 2020
Merged
@Jason-Morcos Jason-Morcos linked a pull request Nov 19, 2020 that will close this issue
Release 2.3.1 after App Store Approval #520
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Release 2.3.1 after App Store Approval Sequel-Ace/Sequel-Ace
2 participants
@Kaspik @Jason-Morcos