Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress window is modal #fixed #1888

Merged
merged 1 commit into from Oct 16, 2023
Merged

Conversation

Tantalon
Copy link
Contributor

Changes:

  • Fix for window losing focus introduced a regression - the progress window is no longer modal. This is because setIsVisible:false has the side-effect of disassociating the window from its parent. This pull request fixes it in a different way - replace removeChildWindow with orderOut. This stops Sequel-Ace from losing focus, while retaining the parent relationship and the modal behavior.

Closes following issues:

Tested:

  • Processors:
    • Intel
    • Apple Silicon
  • macOS Versions:
    • 10.13.x (High Sierra)
    • 10.14.x (Mojave)
    • 10.15.x (Catalina)
    • 11.x (Big Sur)
    • 12.x (Monterey)
    • 13.x (Ventura)
    • 14.x (Sonoma)
  • Localizations:
    • English
    • Spanish
    • Other (please specify)
  • Xcode Version: 15.0

Copy link
Member

@Jason-Morcos Jason-Morcos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Jason-Morcos Jason-Morcos merged commit 014267d into Sequel-Ace:main Oct 16, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Running query modal window is not modal anymore
3 participants