Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 323 - Potentially fix Custom Bundle Keyboard Shortcuts require (re)activation after update #383

Conversation

Jason-Morcos
Copy link
Member

@Jason-Morcos Jason-Morcos commented Oct 2, 2020

What does this implement/fix? Explain your changes.

Attempted to fix issue 323 regarding third-party bundles not getting keyboard shortcuts applied on upgrade. Still possibly a hole and needs some testing, but thought I would open PR in case someone has a chance to give this thorough review and some solid testing.

Does this close any currently open issues?

Attempt at fixing #323

This needs more testing before we should merge it.

…uire-reactivation-after-Update

* main:
  Perfect alignment
  Move bracket highlighting setting to sit next to syntax highlighting setting
  Adjust about version display
@Jason-Morcos Jason-Morcos self-assigned this Oct 2, 2020
…uire-reactivation-after-Update

* main:
  Fix wrong imports and warnings on XCode 12
  Add complexity script
  Move file to match XCode organizer
@Jason-Morcos
Copy link
Member Author

This now offers quite a few stability fixes to bundle updating, but I'm not certain it fixes #323 as I can't repro 323, but I did patch some possible holes. If you have a chance to look at this, @Kaspik, that would be great. No urgency here though!

Copy link
Member

@Kaspik Kaspik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, don§t think it fixes #323 , but the changes here are nice. :)

@Jason-Morcos Jason-Morcos merged commit 19286bc into main Oct 5, 2020
@Jason-Morcos Jason-Morcos deleted the 323-fix-Custom-Bundle-Keyboard-Shortcuts-require-reactivation-after-Update branch October 5, 2020 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants