Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Beta 1 & 2 fixes, crash fixes, fix table content positioning #fixed #575

Merged
merged 14 commits into from
Dec 1, 2020
Merged

Beta 1 & 2 fixes, crash fixes, fix table content positioning #fixed #575

merged 14 commits into from
Dec 1, 2020

Conversation

Kaspik
Copy link
Member

@Kaspik Kaspik commented Nov 30, 2020 •
edited

Changes:

  • show alert on main
  • fix crash when database has views
  • fix crash if error detail is nil
  • fix preserving content offset when sorting by column
  • fix field editor in table content view
  • fix high CPU usage for bracket highlight in bigger queries
  • fix query editor highlight when opening spfs files
  • fix sidebar (table list) background to be blur as native sidebars

Closes following issues:

Tested:

  • Processors:
    • Intel
    • Apple Silicon
  • macOS versions:
    • 10.12
    • 10.13
    • 10.14
    • 10.15
    • 11.0
  • Xcode version: 12.2

Screenshots:

Screen Shot 2020-12-01 at 14 38 44
Screen Shot 2020-12-01 at 14 43 23

Additional notes:

  • Fixed two more crashes that I found

@Kaspik Kaspik mentioned this pull request Dec 1, 2020
Closed
@Kaspik Kaspik changed the title Fix crashes in Beta 1 #fixed Fix crashes in Beta 1, fix table content positioning #fixed Dec 1, 2020
@Kaspik Kaspik changed the title Fix crashes in Beta 1, fix table content positioning #fixed Beta 1 & 2 fixes, crash fixes, fix table content positioning #fixed Dec 1, 2020
@Jason-Morcos Jason-Morcos merged commit 8b73fb1 into main Dec 1, 2020
@Jason-Morcos Jason-Morcos deleted the fixCrash branch December 1, 2020 17:00
@dnicolson
Copy link
Contributor

@Kaspik is intentional in 81f38b7#diff-eef2bbe7c4f50b4506bd369348c223a35433a9786769bec6e4c03b1855f573b9R2448 to duplicate error messages?

Access denied!

@Kaspik
Copy link
Member Author

Kaspik commented Mar 15, 2021

Pfff, probably not!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jason-Morcos Jason-Morcos Jason-Morcos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

High CPU Usage when editing large queries Crashes When Viewing MySQL "View" Content
3 participants
@Kaspik @dnicolson @Jason-Morcos