#added Ability to choose custom known_hosts file #906
Conversation
only shows if there is a connection via SSh tunnel.
There was a problem hiding this comment.
Awesome job, @jamesstout! Haven't tried code locally yet, but looks like it should work very well. We'll just need to test thoroughly before release
* main: rm reverse2 nil guards null guard bounds guards safeSetArray # Conflicts: # Source/Other/CategoryAdditions/SPMutableArrayAdditions.h # Source/Other/CategoryAdditions/SPMutableArrayAdditions.m
* main: allow insertion of NULL into varchar fields of length < 4
this is for when we find things like: Include ~/.ssh/ssh_conf UserKnownHostsFile ~/.ssh/known_hosts in a config file. We need to expand for bookmark generation. Needs tests....
* main: Increment build version Increment app patch version fix some analyzer warnings tableSyntax unboxNull safeObjectAtIndex for primaryKeyFieldNames tidy tests for separatedIntoLinesByCharsetObjC expose separatedIntoLinesByCharsetObjC to objc save individually now splits on ; added separatedIntoLinesByCharset resetFilter calls toggleRuleEditorVisible and sets state of toggleRuleFilterButton expose toggleRuleFilterButton # Conflicts: # Source/Controllers/Preferences/Panes/SPNetworkPreferencePane.h # Source/Other/CategoryAdditions/SPMutableArrayAdditions.h # Source/Other/Utility/SPPanelOptions.h
* main: check pref SPEditInSheetForLongTextLengthThreshold is actually an integer ensure we have valid value for editInSheetForLongTextLengthThreshold WIP # Conflicts: # Interfaces/Preferences.xib
* main: needs to be on main loop SPTaskAdditions catch exceptions before MSACCrashes added sshProcessIDs array of pids launched by the tunnel # Conflicts: # sequel-ace.xcodeproj/project.pbxproj
|
We may want to briefly hold on merging this until we get the release of 3.2.3 out. Then make this the banner feature for 3.3? |
sure .. no probs |
|
I'm happy to help test this once there's a build available, my workstation isn't current set up to build it. I don't think this should close #867, although it will help. |
* main: No Newer Release Available info alert
* main: added ByteCountFormatterExtension.swift to unit test target faster-stringForByteSize # Conflicts: # sequel-ace.xcodeproj/project.pbxproj
|
3.2.3 is out, ready to go @Jason-Morcos ? |
Changes:
Closes following issues:
Tested:
Screenshots:
Prefs
Help Menu
SSH Tunnel Debugging Info
Scanning configs for UserKnownHostsFile and parsing the file
Additional notes:
Doesn't quite solve for #867If you set a custom known_hosts file, SA creates a RW bookmark, adds it to prefs and then uses it in the command:
Used command: /usr/bin/ssh -v -N -S none -o ControlMaster=no -o ExitOnForwardFailure=yes -o ConnectTimeout=10 -o NumberOfPasswordPrompts=3 -o UserKnownHostsFile=/Users/james/.ssh/known_hostsChecks it's writable etc.