Remove titleAccessoryView #removed

[Kaspik]

Changes:

• Remove titleaccessoryView as it's not used anyways anymore

Closes following issues:

• Closes: Nothing

Tested:

• Processors:
  • Intel
  • Apple Silicon
• macOS Versions:
  • 10.12.x (Sierra)
  • 10.13.x (High Sierra)
  • 10.14.x (Mojave)
  • 10.15.x (Catalina)
  • 11.x (Big Sur)
• Xcode Version:
• Localizations:
  • English
  • Spanish
  • Other (please specify)

Screenshots:

Additional notes:

I have no idea what this view was supposed to do but I can't see it anywhere and I don't see a difference when removing it. It might improve #857

[Jason-Morcos]

Looks okay, are we certain we're not using this to show the "SSH Connected" stuff?
Let's hold until after the 3.2.3 release, just so we can test to make sure no funky edge cases before pushing. I'm pushing 3.2.3 to apple now, but let's hold until it's actually approved and out (I'm a little concerned @jamesstout's awesome "check for update" change will cause us to get rejected and we may have to disable it in the App Store version somehow.)

[Kaspik]

I have no idea, but iirc that was funky-broken too, right? 😂 Yeah I'm okay with merging tomorrow.

[Jason-Morcos]

I have no idea, but iirc that was funky-broken too, right? 😂 Yeah I'm okay with merging tomorrow.

A little funky but still mostly working lol

[Kaspik]

Why would we be hiding it on full screen, and why do we have image there (in the xib) for this? 🤷🏻‍♂️

[Jason-Morcos]

Why would we be hiding it on full screen, and why do we have image there (in the xib) for this? 🤷🏻‍♂️

Good point, looks like it indeed is just some silly legacy thing. Good to remove, next release :)

[Kaspik]

3.2.3 is out 🎉