New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows & Tabs refactoring: Remove Custom tabbing, implement native tabbed windows, rewrite app structure & hierarchy #changed #970
Conversation
Windows rewrite: Part 3 - Enable system native tabbing
Windows rewrite: Part 2 - Rewrite SPWindowController to Swift
Windows rewrite: Part 1 - Remove PSMTabBarControl and disable tabbing
…t are not used anymore
Windows rewrite: Part 5 - Simplfy connection between window and database document
… of spdatabase document to app controller, fix spfs association, fix reopening spfs
Windows rewrite: Part 6 - Database document cleanup
Windows rewrite: Part 9 - Completely refactor Main Menu actions, fix reopen, fix connection UI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work!
Any way we could make the tab color more clear for tabs? A little more like the old way if possible? At the minimum, maybe changing the color of the tab title at least?
I like the smaller color indicator, and might start using colors now for my favorites. :) When the full tab is colored, it makes it hard to tell which tab is currently selected, and it doesn't look as "native." |
Yes and no. You can make it whatever size you want, but it would be above the title. Making it bigger after the title means possible conflicts with longer titles... Making it 4:1 with sharp corners is ugly, with rounded corners it's weird... so circle it is for now. 😄 We might tweak the colors! |
Changes:
tabbedWindows
architectureCloses following issues:
Tested:
Screenshots:
Default
Option to hide tab bar when there is only on tab:
Multiple tabs, favorite color:
SSL connection:
NEW - all native stuff, like show all tabs:
Additional notes:
Opening this PR now as it seems like it's good for internal testing. All issues found should be added to the created project and I'll prioritize them as it comes. I'm pretty sure there are and there will be bugs, but I don't think I'm able to find them all.
EVERYTHING was reviewed by sub-PRs by @Jason-Morcos , so this review should be easier to do if you even want to do a review instead of just quick sanity check.