Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows & Tabs refactoring: Remove Custom tabbing, implement native tabbed windows, rewrite app structure & hierarchy #changed #970

Merged
merged 52 commits into from Mar 17, 2021

Conversation

Kaspik
Copy link
Member

@Kaspik Kaspik commented Mar 14, 2021

Changes:

  • completely remove PSMTabBar
  • start using native tabbedWindows architecture
  • rewamp Main Menu actions
  • simplify hierarchy for AppController => Window => Window Controller => Database document

Closes following issues:

Tested:

  • Processors:
    • Intel
    • Apple Silicon
  • macOS Versions:
    • 10.12.x (Sierra)
    • 10.13.x (High Sierra)
    • 10.14.x (Mojave)
    • 10.15.x (Catalina)
    • 11.x (Big Sur)
  • Localizations:
    • English
    • Spanish
    • Other (please specify)
  • Xcode Version: 12.4

Screenshots:

Default

Screenshot 2021-03-14 at 15 23 08

Option to hide tab bar when there is only on tab:

111072077-5001d880-84d9-11eb-8368-6b763e77f59f

Multiple tabs, favorite color:

Screenshot 2021-03-14 at 15 20 30

SSL connection:

Screenshot 2021-03-14 at 15 20 30

NEW - all native stuff, like show all tabs:

Screenshot 2021-03-14 at 15 21 33

Additional notes:

Opening this PR now as it seems like it's good for internal testing. All issues found should be added to the created project and I'll prioritize them as it comes. I'm pretty sure there are and there will be bugs, but I don't think I'm able to find them all.

EVERYTHING was reviewed by sub-PRs by @Jason-Morcos , so this review should be easier to do if you even want to do a review instead of just quick sanity check.

Kaspik added 30 commits March 7, 2021 19:38
Windows rewrite: Part 3 - Enable system native tabbing
Windows rewrite: Part 2 - Rewrite SPWindowController to Swift
Windows rewrite: Part 1 - Remove PSMTabBarControl and disable tabbing
Windows rewrite: Part 5 - Simplfy connection between window and database document
… of spdatabase document to app controller, fix spfs association, fix reopening spfs
@Kaspik Kaspik added this to In progress in Native Tabs instead of PSMTabBar via automation Mar 14, 2021
@Kaspik Kaspik added Feature Request New feature or request WIP and removed WIP labels Mar 14, 2021
@Kaspik Kaspik marked this pull request as ready for review March 15, 2021 10:39
Native Tabs instead of PSMTabBar automation moved this from In progress to Reviewer approved Mar 17, 2021
Copy link
Member

@Jason-Morcos Jason-Morcos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!
Any way we could make the tab color more clear for tabs? A little more like the old way if possible? At the minimum, maybe changing the color of the tab title at least?

@samuelbradshaw
Copy link

samuelbradshaw commented Mar 17, 2021

I like the smaller color indicator, and might start using colors now for my favorites. :) When the full tab is colored, it makes it hard to tell which tab is currently selected, and it doesn't look as "native."

@Kaspik
Copy link
Member Author

Kaspik commented Mar 17, 2021

Yes and no. You can make it whatever size you want, but it would be above the title. Making it bigger after the title means possible conflicts with longer titles... Making it 4:1 with sharp corners is ugly, with rounded corners it's weird... so circle it is for now. 😄 We might tweak the colors!

@Kaspik Kaspik enabled auto-merge March 17, 2021 21:13
@Kaspik Kaspik merged commit c5f1a35 into main Mar 17, 2021
Native Tabs instead of PSMTabBar automation moved this from Reviewer approved to Done Mar 17, 2021
@Kaspik Kaspik deleted the windows/develop branch March 17, 2021 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request New feature or request
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

please add a preference to hide tab bar Window tab bar implementation click and drag problems
3 participants