Make Composer scan all files in src/ #646
Conversation
| "php": "^5.6 || ^7.0 || ^8.0", | ||
| "ext-curl": "*", | ||
| "ext-fileinfo": "*", | ||
| "ext-json": "*", | ||
| "ext-zlib": "*" |
There was a problem hiding this comment.
I do not know where it came from...
There was a problem hiding this comment.
The ext- ones can be removed for sure. They were added because of a linter nag but they caused more problems than solved.
There was a problem hiding this comment.
Thanks for the PR! Autoloading everything under src/ is something I want to do soon but I don't think the codebase is ready for that yet. We still have some files left which can't be autoloaded like:
- https://github.com/Seravo/seravo-plugin/blob/master/src/modules/postbox-init.php
- Waiting for upcoming rewrite of
lib/postbox/handler.php
- Waiting for upcoming rewrite of
- https://github.com/Seravo/seravo-plugin/blob/master/src/lib/canonical-domain-and-https.php
- Waiting to be converted to use
Moduletrait. Not sure if it can be done yet.
- Waiting to be converted to use
- https://github.com/Seravo/seravo-plugin/blob/master/src/modules/seravo-cli.php
- Requires conditional loading as the SeravoCLI class extends
WP_CLI_Commandwhich isn't always available.
- Requires conditional loading as the SeravoCLI class extends
| "php": "^5.6 || ^7.0 || ^8.0", | ||
| "ext-curl": "*", | ||
| "ext-fileinfo": "*", | ||
| "ext-json": "*", | ||
| "ext-zlib": "*" |
There was a problem hiding this comment.
The ext- ones can be removed for sure. They were added because of a linter nag but they caused more problems than solved.
With |
What are the main changes in this PR?
Simplify Composer autoloader's configuration.
@JoosuaKoskinen
Big win! 🎉