Refactor rspec tests

[onnimonni]

This contains Refactoring of rspec tests.

I added all wordpress related functions into their own static module WP which can be found in tests/rspec/lib/wp.rb

This makes the rspec tests so much more readable.

[onnimonni]

@anttiviljami if travis tests passes this should be good to go :).

[ottok]

This pull request contains in fact two issues: using .local for domain names and refactored rspec tests.

About rspec refactoring: So now test.rb calls for config.rb which includes a call for wp.rb? So every time config.rb is called in any test, it wp.rb tests will run again and again?

In bus.fi project we have a script that runs all tests that are in patch tests/rspec/*. With this architecture it is easy to write tests for projects without overlapping the upstream namespace, so it is possible to update to new versions of seravo/wordpress.

Actually that script is already in this project (https://github.com/Seravo/wordpress/blob/master/scripts/run-tests) but Travis-CI call test.rb directly instead of running the run-tests.sh script.

The README could say more than just that 'test.rb' is an example. It could for example say, that if a user wants to make their own tests, all they need to do is copy test.rb into a new filename and then write their own tests there. Test.rb could stay in place as it contains good basic test.

What happens to existing tests? Will this change break compatibility with existing projects that have already been developed with seravo/wordpress as a starting point? Hmm.. looking at current bus.fi sources if does not contain any calls to config.rb, only 'lib/matchers.rb' so it is probably not compatible with this project template anyway anymore.

[anttiviljami]

why do we need this ? shouldn't it be *.wp-palvelu.local anyway? usually you just configure the domains you need to use for this site in the config.yml, for which the example file already contains this entry. See: https://github.com/Seravo/wordpress/blob/master/config-sample.yml#L13

[onnimonni]

I moved that for other branch, but we need to have HTTPS_DOMAIN_ALIAS defined so that users can test https domain alias in vagrant. Is this what you're asking for?

[onnimonni]

@otto: Sorry I accidentally added two features simultaneously. I fixed some parts out of this PR and moved local network features to this PR: #18

I don't believe we can support automatic compatibility with this upstream in child projects. It's up to those projects whether they wan't to use new features or not? This is just like they do it in our counterpart: https://github.com/roots/bedrock

If you want to have multiple test files you should only add lib/config.rb once for better performance.