Sereal::Path: stop leaking stack in srl_iterator.c

Sereal · Feb 19, 2017 · b5460b1 · b5460b1
1 parent 26c4e6d
commit b5460b1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/Perl/Path/Iterator/srl_iterator.c b/Perl/Path/Iterator/srl_iterator.c
@@ -287,6 +287,8 @@ srl_deinit_iterator(pTHX_ srl_iterator_t *iter)
 
     if (iter->document)
         SvREFCNT_dec(iter->document);
+
+    srl_stack_deinit(aTHX_ &iter->stack);
 }
 
 void

diff --git a/Perl/shared/srl_stack.h b/Perl/shared/srl_stack.h
@@ -84,9 +84,9 @@ srl_stack_grow(pTHX_ srl_stack_t *stack)
 
 /* Free stack arrfer (not not the stack struct */
 SRL_STATIC_INLINE void
-srl_stack_destroy(pTHX_ srl_stack_t *stack)
+srl_stack_deinit(pTHX_ srl_stack_t *stack)
 {
-    if (stack == NULL) return;
+    if (stack == NULL || stack->begin == NULL) return;
     Safefree(stack->begin);
 }