Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: askRequire didn't work #89

Merged
merged 1 commit into from
Aug 3, 2023
Merged

fix: askRequire didn't work #89

merged 1 commit into from
Aug 3, 2023

Conversation

Lampese
Copy link
Contributor

@Lampese Lampese commented Aug 3, 2023

No description provided.

@Lampese Lampese requested a review from MeowShe August 3, 2023 15:55
@MeowShe
Copy link
Collaborator

MeowShe commented Aug 3, 2023

I recommend edit the commit message to fix: ... didn't work instead of fix: ... don't work.

But the fix is correct, so I approved it.

@Lampese
Copy link
Contributor Author

Lampese commented Aug 3, 2023

I recommend edit the commit message to fix: ... didn't work instead of fix: ... don't work.

But the fix is correct, so I approved it.

I will fix it then.

@Lampese Lampese changed the title fix: askRequire don't work fix: askRequire didn't work Aug 3, 2023
@Lampese Lampese merged commit 3125943 into main Aug 3, 2023
4 checks passed
@Lampese Lampese deleted the Lampese-patch-1 branch August 3, 2023 16:00
@Lampese
Copy link
Contributor Author

Lampese commented Aug 3, 2023

I recommend edit the commit message to fix: ... didn't work instead of fix: ... don't work.

But the fix is correct, so I approved it.

I will fix it then.

I'm so sorry for my error that I only edit the name of pr and ignored the pr name isn't linked with commit message.

Because of Github Mobile, I got this mistake.

I will amend to solve this mistake tomorrow, before it we shouldn't create new commits.

Lampese added a commit that referenced this pull request Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants