LibWeb: Use [Reflect] to implement HTMLPreElement.width

SerenityOS · May 21, 2024 · b401fc0 · b401fc0
1 parent baf8284
commit b401fc0
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 20 deletions.
diff --git a/Userland/Libraries/LibWeb/HTML/HTMLPreElement.cpp b/Userland/Libraries/LibWeb/HTML/HTMLPreElement.cpp
@@ -38,20 +38,4 @@ void HTMLPreElement::apply_presentational_hints(CSS::StyleProperties& style) con
     });
 }
 
-// https://html.spec.whatwg.org/multipage/obsolete.html#dom-pre-width
-WebIDL::Long HTMLPreElement::width() const
-{
-    // The width IDL attribute of the pre element must reflect the content attribute of the same name.
-    if (auto width_string = get_attribute(HTML::AttributeNames::width); width_string.has_value()) {
-        if (auto width = parse_integer(*width_string); width.has_value())
-            return *width;
-    }
-    return 0;
-}
-
-WebIDL::ExceptionOr<void> HTMLPreElement::set_width(WebIDL::Long width)
-{
-    return set_attribute(HTML::AttributeNames::width, MUST(String::number(width)));
-}
-
 }
diff --git a/Userland/Libraries/LibWeb/HTML/HTMLPreElement.h b/Userland/Libraries/LibWeb/HTML/HTMLPreElement.h
@@ -22,9 +22,6 @@ class HTMLPreElement final : public HTMLElement {
     // https://www.w3.org/TR/html-aria/#el-pre
     virtual Optional<ARIA::Role> default_role() const override { return ARIA::Role::generic; }
 
-    WebIDL::Long width() const;
-    WebIDL::ExceptionOr<void> set_width(WebIDL::Long);
-
 private:
     HTMLPreElement(DOM::Document&, DOM::QualifiedName);
 

diff --git a/Userland/Libraries/LibWeb/HTML/HTMLPreElement.idl b/Userland/Libraries/LibWeb/HTML/HTMLPreElement.idl
@@ -7,6 +7,6 @@ interface HTMLPreElement : HTMLElement {
     [HTMLConstructor] constructor();
 
     // Obsolete
-    [CEReactions] attribute long width;
+    [CEReactions, Reflect] attribute long width;
 
 };