Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LibWeb: Three boxes with width 33.3333% don't always fit next to each other #22610

Closed
awesomekling opened this issue Jan 5, 2024 · 1 comment 路 Fixed by #22613
Closed

LibWeb: Three boxes with width 33.3333% don't always fit next to each other #22610

awesomekling opened this issue Jan 5, 2024 · 1 comment 路 Fixed by #22613
Labels
bug Something isn't working has-repro We have a way to reproduce this bug.

Comments

@awesomekling
Copy link
Collaborator

Seems like something goes wrong with the fixed-point math somewhere 馃槄

<!doctype html><style>
    body {
        background: black;
    }
    div {
        display: inline-block;
        width: 33.3333%;
        height: 100px;
        background: orange;
    }
</style><body><div></div><div></div><div></div>
untitled.mp4
@awesomekling awesomekling added bug Something isn't working has-repro We have a way to reproduce this bug. labels Jan 5, 2024
kalenikaliaksandr added a commit to kalenikaliaksandr/serenity that referenced this issue Jan 6, 2024
@kalenikaliaksandr
LibWeb: Remove rounding division for CSSPixels
c05a006 
Reverts 98926b4
that regressed (thrashing layout while window resizing):
Tests/LibWeb/Layout/input/block-and-inline/small-percentage-margin.html

Unfortunately, we currently can't capture such problems with layout
tests, so this bug went unnoticed for quite a long time.

Fixes SerenityOS#22610
@kalenikaliaksandr kalenikaliaksandr mentioned this issue Jan 6, 2024
Merged
kalenikaliaksandr added a commit to kalenikaliaksandr/serenity that referenced this issue Jan 6, 2024
@kalenikaliaksandr
LibWeb: Remove rounding division for CSSPixels
48a8466 
Reverts 98926b4
that regressed (thrashing layout while window resizing):
Tests/LibWeb/Layout/input/block-and-inline/small-percentage-margin.html

Unfortunately, we currently can't capture such problems with layout
tests, so this bug went unnoticed for quite a long time.

Fixes SerenityOS#22610
@awesomekling
Copy link
Collaborator Author

Here's a version of the test that always fails currently without needing to resize:

<!doctype html><style>
    body {
        background: black;
        width: 620px;
    }
    div {
        display: inline-block;
        width: 33.3333%;
        height: 100px;
        background: orange;
    }
</style><body><div></div><div></div><div></div>

kalenikaliaksandr added a commit to kalenikaliaksandr/serenity that referenced this issue Jan 6, 2024
@kalenikaliaksandr
LibWeb: Remove rounding division for CSSPixels
f97e878 
Reverts 98926b4
that regressed: block-and-inline/small-percentage-margin.html
(thrashing layout while window resizing)

Fixes SerenityOS#22610
awesomekling pushed a commit that referenced this issue Jan 6, 2024
@kalenikaliaksandr @awesomekling
LibWeb: Remove rounding division for CSSPixels
e7eaf3b 
Reverts 98926b4
that regressed: block-and-inline/small-percentage-margin.html
(thrashing layout while window resizing)

Fixes #22610
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working has-repro We have a way to reproduce this bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

LibWeb: Remove rounding division for CSSPixels kalenikaliaksandr/serenity
1 participant
@awesomekling