Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LibWeb: VERIFICATION FAILED: glGetError() == GL_NO_ERROR on komplett.se #22879

Closed
awesomekling opened this issue Jan 20, 2024 · 0 comments · Fixed by #22886
Closed

LibWeb: VERIFICATION FAILED: glGetError() == GL_NO_ERROR on komplett.se #22879

awesomekling opened this issue Jan 20, 2024 · 0 comments · Fixed by #22886
Labels
bug Something isn't working has-repro We have a way to reproduce this bug. web compatibility

Comments

@awesomekling
Copy link
Collaborator

To reproduce, open https://komplett.se/ and wait a while.

Eventually, you get this crash:

VERIFICATION FAILED: glGetError() == GL_NO_ERROR at /home/kling/src/serenity/Userland/Libraries/LibAccelGfx/GL.cpp:17
/home/kling/src/serenity/Build/lagom/lib/liblagom-core.so.0(ak_verification_failed+0xef) [0x7efc021b6bff]
/home/kling/src/serenity/Build/lagom/lib/liblagom-accelgfx.so.0(+0x8c8e) [0x7efc02aa6c8e]
/home/kling/src/serenity/Build/lagom/lib/liblagom-web.so.0(+0xace06b) [0x7efc014ce06b]
/home/kling/src/serenity/Build/lagom/lib/liblagom-web.so.0(+0xace427) [0x7efc014ce427]
/home/kling/src/serenity/Build/lagom/lib/liblagom-web.so.0 Web::WebGL::WebGLRenderingContextBase::~WebGLRenderingContextBase() 0x2c) [0x7efc014d025c]
/home/kling/src/serenity/Build/lagom/lib/liblagom-js.so.0 JS::HeapBlock::deallocate(JS::Cell*) 0xa4) [0x7efc00077384]
/home/kling/src/serenity/Build/lagom/lib/liblagom-js.so.0(+0x272e01) [0x7efc00072e01]
/home/kling/src/serenity/Build/lagom/lib/liblagom-js.so.0 JS::Heap::sweep_dead_cells(bool, Core::ElapsedTimer const&) 0x13c) [0x7efc00071b0c]
/home/kling/src/serenity/Build/lagom/lib/liblagom-js.so.0 JS::Heap::collect_garbage(JS::Heap::CollectionType, bool) 0x64) [0x7efc00071364]
/home/kling/src/serenity/Build/lagom/lib/liblagom-js.so.0 JS::Heap::will_allocate(unsigned long) 0x34) [0x7efc00071404]

cc @kalenikaliaksandr
@awesomekling awesomekling added bug Something isn't working web compatibility has-repro We have a way to reproduce this bug. labels Jan 20, 2024
kalenikaliaksandr added a commit to kalenikaliaksandr/serenity that referenced this issue Jan 21, 2024
@kalenikaliaksandr
LibWeb/WebGL: Activate context in AccelGfxContext destructor
21299ab 
Before running the destructor of AccelGfxContext members, we need to
ensure that the correct context is active so that framebuffer owned by
AccelGfx::Canvas could be destroyed.

Fixes SerenityOS#22879
kalenikaliaksandr added a commit to kalenikaliaksandr/serenity that referenced this issue Jan 21, 2024
@kalenikaliaksandr
LibWeb/WebGL: Activate context in AccelGfxContext destructor
e564dcf 
Destructor of AccelGfxContext needs to make sure that correct OpenGL
context is active so that destructors of its members could proceed
destroying they resources (for example framebuffer owned by
AccelGfx::Canvas).

Fixes SerenityOS#22879
@kalenikaliaksandr kalenikaliaksandr mentioned this issue Jan 21, 2024
Merged
kalenikaliaksandr added a commit to kalenikaliaksandr/serenity that referenced this issue Jan 21, 2024
@kalenikaliaksandr
LibWeb/WebGL: Switch context in AccelGfxContext destructor
66f01ee 
Destructor of AccelGfxContext needs to make sure that correct OpenGL
context is active so that destructors of its members could proceed
destroying they resources (for example framebuffer owned by
AccelGfx::Canvas).

Fixes SerenityOS#22879
awesomekling pushed a commit that referenced this issue Jan 21, 2024
@kalenikaliaksandr @awesomekling
LibWeb/WebGL: Switch context in AccelGfxContext destructor
2136471 
Destructor of AccelGfxContext needs to make sure that correct OpenGL
context is active so that destructors of its members could proceed
destroying they resources (for example framebuffer owned by
AccelGfx::Canvas).

Fixes #22879
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working has-repro We have a way to reproduce this bug. web compatibility
Projects
No open projects
Ladybird
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

LibWeb/WebGL: Switch context in AccelGfxContext destructor kalenikaliaksandr/serenity
1 participant
@awesomekling