Ports: Make openssh server not crash during startup and update from 8.3 to 9.0 #13846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HerrSpace
force-pushed
the
ports-openssh-server
branch
from
ed782e0
to
83f9c75
Compare
HerrSpace
changed the title
|
Can you add more details to the commit message / title for |
HerrSpace
force-pushed
the
ports-openssh-server
branch
2 times, most recently
from
ec2db1f
to
0a92caa
Compare
Before, the openssh server tried to chroot. The startup always aborted after that, as our chroot stub currently simply returns -1. Luckily we can use unveil instead. Furthermore the missing ssh_host_ed25519_key also prevented the server from successfully starting. The previous ReadMe.md entry about socketpair missing was already resolved by SerenityOS#6705.
HerrSpace
force-pushed
the
ports-openssh-server
branch
from
0a92caa
to
34710f5
Compare
HerrSpace
changed the title
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out we were already pretty close to a working openssh server :^)