Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LibJS: Add parsed parameters to FunctionDeclaration #1439

Conversation

linusg
Copy link
Member

@linusg linusg commented Mar 13, 2020

This patch will update Parser::parse_function_declaration() to pass the the parsed parameter names to the FunctionDeclaration.

This makes the js/function-with-arguments.js script work and not choke on ASSERT when trying to add (as in +) two undefined arguments.

@awesomekling awesomekling merged commit 0e04e2c into SerenityOS:master Mar 13, 2020
@linusg linusg deleted the libjs-add-parsed-parameters-to-functiondeclaration branch March 13, 2020 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants