Base: Update Durrque theme for a better look and feel #15234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djwisdom
force-pushed
the
base-update-durrque-theme
branch
from
fdd6aa1
to
3e0c6d0
Compare
|
Nitpick: Please fix the commit message to be have proper grammar. |
djwisdom
force-pushed
the
base-update-durrque-theme
branch
from
3e0c6d0
to
68e7c45
Compare
djwisdom
changed the title
|
Nice idea with the glow effect, much easier to see than the shadow was. :^) |
|
Is Base/res/icons/themes/Durrque/frame-half-shadow-light.png used for anything? If so, how? |
|
Good catch! I was experimenting with reversing the frame shadow color to produce the 'glow' effect, totally missed removing that png. Currently frame-half-shadow-light.png is no longer used in Durrque theme. You are encouraged to remove it and submit a PR. :^) |
nico
added a commit
to nico/serenity
that referenced
this pull request
Jun 15, 2023
trflynn89
pushed a commit
that referenced
this pull request
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
Snapshot above sports Durrque theme + Durrque font + Durrque icons + Durrque cursor