LibWeb: Implement background-position-x and background-position-y longhand longhands
#18157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This solves the longhands must be initialized before shorthands problem by just initializing the value when it is first requested. This will be needed for background-position-x/y which is a longhand of a longhand, which otherwise breaks the longhands before shorthands rule.
github-actions
bot
added
the
👀 pr-needs-review
AtkinsSJ
reviewed
Apr 2, 2023
If background-position was not longhand enough for you, we've now got background-position-x and background-position-y :^)
This represents a single edge and offset, this will be needed for the values of background-position-x/y.
This parses the new background-position-x/y longhands and properly hooks up them up. This requires converting PositionStyleValue to just contain two EdgeStyleValues so that it can be easily expanded into the longhands.
MacDue
force-pushed
the
css-bg4-pos-longhands
branch
from
006c96a
to
96fd488
Compare
github-actions
bot
removed
the
👀 pr-needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is technically from CSS Backgrounds and Borders Module Level 4, which has this neat looking banner at the bottom:
However, these properties are in use on real websites and are needed to fix the left button on https://store.steampowered.com/: