LibWeb/HTMLInputElement: Improve appearance of color picker #21438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
👀 pr-needs-review
11 tasks
trflynn89
reviewed
Oct 13, 2023
AtkinsSJ
requested changes
Oct 13, 2023
Previously, all input elements were given a textbox-like style by default, this was then undone by another CSS rule in the case of certain types of input element. This commit makes it so that the first rule simply ignores those types instead. Co-authored-by: Sam Atkins <atkinssj@serenityos.org>
Instead of a plain ButtonBox, it now appears as a color well styled after the buttons.
github-actions
bot
removed
the
👀 pr-needs-review
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of a plain ButtonBox, it now appears as a color well styled after the buttons.
2023-10-13.20-17-56.mp4