Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LibGfx/TIFF: Support samples with a floating point value #23519

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

LucasChollet
Copy link
Member

@LucasChollet LucasChollet commented Mar 8, 2024

The test cases were generated using this Python code (no extratags were
given for float32_no_tags):

import tifffile
import numpy as np
image = np.array(
                [[[0, 0, 0], [255, 0, 0]],
                [[0, 127.5, 127.5], [255, 255, 255]]]
            ).astype(np.float32)
tifffile.imwrite('float32.tiff', image / 255, extratags=[
        (340, 11, 3, [0, 0, 0], True),
        (341, 11, 3, [1, 1, 1], True)])

@github-actions github-actions bot added the 👀 pr-needs-review PR needs review from a maintainer or community member label Mar 8, 2024
@nico nico added ⏳ pr-waiting-for-author PR is blocked by feedback / code changes from the author and removed 👀 pr-needs-review PR needs review from a maintainer or community member labels Mar 8, 2024
@github-actions github-actions bot added 👀 pr-needs-review PR needs review from a maintainer or community member and removed ⏳ pr-waiting-for-author PR is blocked by feedback / code changes from the author labels Mar 18, 2024
@LucasChollet LucasChollet added ⏳ pr-waiting-for-author PR is blocked by feedback / code changes from the author and removed 👀 pr-needs-review PR needs review from a maintainer or community member labels Apr 8, 2024
Copy link

stale bot commented May 1, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions!

@stale stale bot added the stale label May 1, 2024
@github-actions github-actions bot added 👀 pr-needs-review PR needs review from a maintainer or community member and removed ⏳ pr-waiting-for-author PR is blocked by feedback / code changes from the author labels May 6, 2024
@stale stale bot removed the stale label May 6, 2024
The test cases were generated using this Python code (no extratags were
given for float32_no_tags):

import tifffile
import numpy as np
image = np.array(
                [[[0, 0, 0], [255, 0, 0]],
                [[0, 127.5, 127.5], [255, 255, 255]]]
            ).astype(np.float32)
tifffile.imwrite('float32.tiff', image / 255, extratags=[
        (340, 11, 3, [0, 0, 0], True),
        (341, 11, 3, [1, 1, 1], True)])
Copy link
Contributor

@nico nico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does anything in the wild use this? Do the uses set the SMin / SMax tags?

Copy link

stale bot commented Jun 5, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions!

@stale stale bot added the stale label Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👀 pr-needs-review PR needs review from a maintainer or community member stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants