LibWeb: Fix my flakey test case + another fix for animation-play-state #23735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way we can just leave it alone if the property hasn't changed. Notably, if the play-state property has been set to 'paused', and then the user gets the animation with JS and calls .play() on it, it should start playing despite the play-state property value.
github-actions
bot
added
the
👀 pr-needs-review
mattco98
force-pushed
the
libweb-animation-flicker-fix
branch
from
9157ec0
to
b27fd00
Compare
|
Well that didn't work. Whatever, just disable the test for now. I have an idea on how to fix all of these issues permanently, but it'll take some work. For now, let's just get CI back 😅 |
ADKaster
approved these changes
Mar 27, 2024
github-actions
bot
removed
the
👀 pr-needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is like my third attempt to get animation-play-state working correctly, so let's hope it actually sticks this time. Note that the new way this test works also functions as a test for the new
animation-play-statebehavior, as the test does not pass without these changes.