Ports: Update freeciv to version 3.1.1 #23882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
👀 pr-needs-review
timschumi
reviewed
Apr 7, 2024
kennethmyhra
force-pushed
the
update-freeciv
branch
from
9f95fa5
to
8859554
Compare
timschumi
requested changes
Apr 8, 2024
There was a problem hiding this comment.
Currently does not build, at least on my machine:
[freeciv/build] ld: /serenity/Toolchain/../Build/x86_64/Root/usr/lib/crt0.o: undefined reference to symbol '__begin_atexit_locking'
[freeciv/build] ld: /serenity/Toolchain/../Build/x86_64/Root/usr/lib/libc.so: error adding symbols: DSO missing from command line
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions! |
github-actions
bot
removed
the
👀 pr-needs-review
kennethmyhra
force-pushed
the
update-freeciv
branch
from
8859554
to
47e15b3
Compare
This formats freeciv's package script according to our ruleset.
Sets '--enable-fcdb=no'. The default has been changed from 'no' in previous versions to 'sqlite3' in this version.
kennethmyhra
force-pushed
the
update-freeciv
branch
from
47e15b3
to
303c957
Compare
kennethmyhra
changed the title
github-actions
bot
added
the
👀 pr-needs-review
|
Figured out why this was failing: The default value for the option Still not sure why it worked on some machines, like my laptop, but I guess that can be a future task for figuring out how to enable sqlite3 for this port. |
timschumi
approved these changes
Jun 2, 2024
github-actions
bot
removed
the
👀 pr-needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
freecivto version 3.1.1.