-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LibWeb: Replace with FlyString #23973
Conversation
Hello! One or more of the commit messages in this PR do not match the SerenityOS code submission policy, please check the |
Hi and welcome to SerenityOS/Ladybird. Please read through our Code Submission Policy and alter your commits accordingly. |
Please build and test your changes on your machine, CI is not a development environment. |
305b324
to
4dd9c10
Compare
I don't see why keep these commits separate, as they all only affect LibWeb. Pleaze squash. I also see you have accidentally created two git identities and that prevents GitHub from associating some of your commits with your account. This can be fixed by setting your git email to the same one set for your GitHub account on both machines. |
LibWeb: DeprecatedFlyString replaced with FlyString LibWeb: Replaced with FlyString. Fixed errors LibWeb: Replaced with FlyString. Fixed errors LibWeb: Replaced with FlyString LibWeb: FlyString replacement LibWeb: Replace with FlyString LibWeb: Replace with FlyString
4dd9c10
to
dd51579
Compare
Thank you for your comment. The commits have been squashed. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions! |
This pull request has been closed because it has not had recent activity. Feel free to re-open if you wish to still contribute these changes. Thank you for your contributions! |
Work on #22447
Thanks!