Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LibWeb: Replace with FlyString #23973

Closed
wants to merge 1 commit into from

Conversation

ryanlee0215
Copy link

Work on #22447

Thanks!

@github-actions github-actions bot added the 👀 pr-needs-review PR needs review from a maintainer or community member label Apr 15, 2024
@BuggieBot
Copy link
Member

Hello!

One or more of the commit messages in this PR do not match the SerenityOS code submission policy, please check the lint_commits CI job for more details on which commits were flagged and why.
Please do not close this PR and open another, instead modify your commit message(s) with git commit --amend and force push those changes to update this PR.

@ryanlee0215 ryanlee0215 changed the title LibWeb: Replace DeprecatedFlyString with FlyString LibWeb: Replace with FlyString Apr 15, 2024
@fdellwing
Copy link
Contributor

Hi and welcome to SerenityOS/Ladybird.

Please read through our Code Submission Policy and alter your commits accordingly.

@trflynn89
Copy link
Member

Please build and test your changes on your machine, CI is not a development environment.

@ryanlee0215 ryanlee0215 force-pushed the LibWeb_flystring branch 3 times, most recently from 305b324 to 4dd9c10 Compare April 18, 2024 17:34
@circl-lastname
Copy link
Contributor

circl-lastname commented Apr 20, 2024

I don't see why keep these commits separate, as they all only affect LibWeb. Pleaze squash.

I also see you have accidentally created two git identities and that prevents GitHub from associating some of your commits with your account. This can be fixed by setting your git email to the same one set for your GitHub account on both machines.

LibWeb: DeprecatedFlyString replaced with FlyString

LibWeb: Replaced with FlyString. Fixed errors

LibWeb: Replaced with FlyString. Fixed errors

LibWeb: Replaced with FlyString

LibWeb: FlyString replacement

LibWeb: Replace with FlyString

LibWeb: Replace with FlyString
@ryanlee0215
Copy link
Author

I don't see why keep these commits separate, as they all only affect LibWeb. Pleaze squash.

I also see you have accidentally created two git identities and that prevents GitHub from associating some of your commits with your account. This can be fixed by setting your git email to the same one set for your GitHub account on both machines.

Thank you for your comment. The commits have been squashed.

Copy link

stale bot commented May 12, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions!

@stale stale bot added the stale label May 12, 2024
Copy link

stale bot commented May 22, 2024

This pull request has been closed because it has not had recent activity. Feel free to re-open if you wish to still contribute these changes. Thank you for your contributions!

@stale stale bot closed this May 22, 2024
@github-actions github-actions bot removed the 👀 pr-needs-review PR needs review from a maintainer or community member label May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants