Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LibWeb: Add shadows to inline text #23986

Closed
wants to merge 4 commits into from
Closed

Conversation

darcusmao
Copy link

Hello, we are students at the University of Utah working on fixing a bug for Professor Panchekha's Web Browser class. We have implemented shadows for inline text as described in the issue #23214. To do this, we used similar code to that used in PaintableWithLines::paint(). The below image shows the inline text before the fix
prefix
This image is what LadyBird looks like after the fix.
Screenshot 2024-04-16 at 10 30 32 AM

@github-actions github-actions bot added the 👀 pr-needs-review PR needs review from a maintainer or community member label Apr 16, 2024
@BuggieBot
Copy link
Member

Hello!

One or more of the commit messages in this PR do not match the SerenityOS code submission policy, please check the lint_commits CI job for more details on which commits were flagged and why.
Please do not close this PR and open another, instead modify your commit message(s) with git commit --amend and force push those changes to update this PR.

@darcusmao darcusmao changed the title LibWeb: Added shadows to inline text LibWeb: Add shadows to inline text Apr 16, 2024
@ADKaster
Copy link
Member

Thanks for fixing this! A couple comments:

  • Can you add one of the reproducers from the issue as a test? A Layout test seems appropriate, given the last example Sam posted. The test should fail without your changes applied, and pass with them.

  • Please fixup-squash your commits and force-push one single commit that has the feature (and its test!) with a detailed commit description. Have a look at this video if you're not sure how to do that. https://youtu.be/ElRzTuYln0M

Copy link

stale bot commented May 22, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions!

@stale stale bot added the stale label May 22, 2024
Copy link

stale bot commented Jun 2, 2024

This pull request has been closed because it has not had recent activity. Feel free to re-open if you wish to still contribute these changes. Thank you for your contributions!

@stale stale bot closed this Jun 2, 2024
@github-actions github-actions bot removed the 👀 pr-needs-review PR needs review from a maintainer or community member label Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants