LibWeb: Add shadows to inline text #23986
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, we are students at the University of Utah working on fixing a bug for Professor Panchekha's Web Browser class. We have implemented shadows for inline text as described in the issue #23214. To do this, we used similar code to that used in PaintableWithLines::paint(). The below image shows the inline text before the fix
![prefix](https://private-user-images.githubusercontent.com/58353461/322926163-b95defbb-4b68-4ec3-b63b-9dc769214a01.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTgzMDU4MTYsIm5iZiI6MTcxODMwNTUxNiwicGF0aCI6Ii81ODM1MzQ2MS8zMjI5MjYxNjMtYjk1ZGVmYmItNGI2OC00ZWMzLWI2M2ItOWRjNzY5MjE0YTAxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MTMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjEzVDE5MDUxNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTdjMzRhOTA0MTk5MjE3MWRjN2M0MmJmYTYwYzlkN2RjZTQ2MzNhNDRhM2ZiNjYwZTMyNjZlYWJiOTY0N2I3YmQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.UTqzVxsjRjBSDySMlP38as1vkVfZR1t7y3V1GfNMdzw)
![Screenshot 2024-04-16 at 10 30 32 AM](https://private-user-images.githubusercontent.com/58353461/322926635-bce97d66-feb7-46ae-9770-9be42a2c900e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTgzMDU4MTYsIm5iZiI6MTcxODMwNTUxNiwicGF0aCI6Ii81ODM1MzQ2MS8zMjI5MjY2MzUtYmNlOTdkNjYtZmViNy00NmFlLTk3NzAtOWJlNDJhMmM5MDBlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MTMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjEzVDE5MDUxNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWVlMGQyNzA3ZGYzYWQ0Nzg1YzY3NDVjMWI4ZGRmNjhjZWM3NjVmYmUxMzRmYjAxODg5MDcwYWQ4YzAxOTZkNTImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0._j0Nm-zMJHcH7G0qjCSBm6f5msvQUVYZkMOuLW2wmIs)
This image is what LadyBird looks like after the fix.