LibWeb: Begin implementing AudioBuffer #24108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
👀 pr-needs-review
shannonbooth
force-pushed
the
audio-buffer-beginnings
branch
from
06db631
to
e345e05
Compare
trflynn89
reviewed
Apr 25, 2024
My clangd was (rightly) complaining that this include was missing.
This was just a trival FIXME to resolve as I was in the area.
The spec doesn't tell us the exact value to use, but a minumum & maximum range of supported values. Just to be consistent with another browser, we follow the values that firefox appears to support from testing the interface on my machine. This function will be used in the AudioBuffer constructor, but is defined in the spec as part of BaseAudioContext.
Implement the constructor and getChannelData function, working towards the functionality that we need in order to implement OfflineAudioContext.
shannonbooth
force-pushed
the
audio-buffer-beginnings
branch
from
e345e05
to
5c158f3
Compare
github-actions
bot
removed
the
👀 pr-needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards OfflineAudioContext (#22902)
And also further work towards #23632