LibWeb: Add skeleton for OfflineAudioContext #24125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement enough to construct the object itself, with most parts stubbed out.
Instead of a cryptic error that occurs due to an interface with no name, fail early on by explicitly checking that an interface was parsed with a name.
We should never hit this case - so don't generate code for it, and instead put in a VERIFY_NOT_REACHED. Also improve the formatting of the generated code to closer match the serenity code style.
The prototype header generation was getting a bit long. This is also a step towards generating code for IDL files only containing an enum definition without any interface. In that case we can't put the enum definitions alongside the prototype - there is no prototype to speak of.
github-actions
bot
added
the
👀 pr-needs-review
github-actions
bot
removed
the
👀 pr-needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a skeleton for OfflineAudioContext to get the boilerplate out of the way.
Work towards #22902 and by extension #23632
Also includes some enum related work in IDL generator as I was investigating how to fix the codegen for an enum with a default value (seen in the IDL definition for OfflineAudioContext).