LibWeb: Implement some more interfaces towards OfflineAudioContext #24195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is still missing a bunch of spec steps to construct the audio node based on the parameters of the OscillatorNode, but it is at least enough to construct an object to be able to add a basic test which can get built upon as more is implemented.
This is just a simple getter which returns the audio context that created this audio node.
This is a simple getter and setter of the OscillatorType enum, with error checking to not allow 'custom', as that should only be changed through 'setPeriodicWave()'.
As a convenient shorthand :^)
github-actions
bot
added
the
👀 pr-needs-review
I can't actually spot in the spec where it explicitly says to pass this through (unlike the AudioContext constructor) - but clearly this needs to be passed through for an OfflineAudioContext to actually have a sample rate!
Which is an AudioParam clamped by the nyquist_frequency.
The spec isn't _super_ clear on how this is meant to be done, but the way I understand this is that we should simply clamp the returned 'current value' between 'min' and 'max'. Firefox does not appear to do this clamping, but Chrome does.
github-actions
bot
removed
the
👀 pr-needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement more of of OscillatorNode, enough to get us up to:
createDynamicsCompressor.Further work to: #22902 / #23632