LibWeb: Do not consume scroll event in PaintableBox without overflow #24228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
👀 pr-needs-review
|
Could you add a text-test for this change please. the test will have to use Also could you check if the change solve #24009 ? if so, please mention the issue in the commit description. |
|
I created a test showing the expected behaviour and added the "fixes #24009" text to the commit text and the GitHub pull request text. |
kalenikaliaksandr
requested changes
May 7, 2024
Specifically, without scrollable overflow. Fixes SerenityOS#24009, both on brave.com and on the reduction.
github-actions
bot
removed
the
👀 pr-needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, without scrollable overflow.
Fixes #24009, both on brave.com and on the reduction.
This fixes the bug that on old reddit with an expando open you could not scroll when having the cursor over the expando. Behaviour is now the same as on Chromium and Firefox.
The issue minimized to the following code: (Where with mouse over the blue box scroll inputs have no effect.)
A process question:
My commit title is less then 70 characters as the pre commit hook required. Would it be okay to expand the github title to longer to include the extra context that this is about scrollable overflow in the title here even if it goes past the 70 character view?