Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LibWeb: Implement the HTMLOutputElement.htmlFor attribute #24344

Merged

Conversation

tcl3
Copy link
Member

@tcl3 tcl3 commented May 16, 2024

This returns a DOMTokenList that reflects the for attribute.

@github-actions github-actions bot added the 👀 pr-needs-review PR needs review from a maintainer or community member label May 16, 2024
@tcl3 tcl3 force-pushed the libweb_output_element_htmlfor_attribute branch from 90300f9 to 50d225c Compare May 16, 2024 20:42
@shannonbooth shannonbooth added ⏳ pr-waiting-for-author PR is blocked by feedback / code changes from the author and removed 👀 pr-needs-review PR needs review from a maintainer or community member labels May 17, 2024
@tcl3 tcl3 force-pushed the libweb_output_element_htmlfor_attribute branch from 50d225c to 00bb154 Compare May 17, 2024 22:42
@github-actions github-actions bot added 👀 pr-needs-review PR needs review from a maintainer or community member and removed ⏳ pr-waiting-for-author PR is blocked by feedback / code changes from the author labels May 17, 2024
@shannonbooth shannonbooth added ✅ pr-community-approved PR has been approved by a community member and removed 👀 pr-needs-review PR needs review from a maintainer or community member labels May 18, 2024
This returns a DOMTokenList that reflects the `for` attribute.
@tcl3 tcl3 force-pushed the libweb_output_element_htmlfor_attribute branch from 00bb154 to 7efdddf Compare May 18, 2024 04:36
@github-actions github-actions bot added 👀 pr-needs-review PR needs review from a maintainer or community member and removed ✅ pr-community-approved PR has been approved by a community member labels May 18, 2024
@shannonbooth shannonbooth added ✅ pr-community-approved PR has been approved by a community member and removed 👀 pr-needs-review PR needs review from a maintainer or community member labels May 18, 2024
@awesomekling awesomekling merged commit 3dc8674 into SerenityOS:master May 18, 2024
11 checks passed
@github-actions github-actions bot removed the ✅ pr-community-approved PR has been approved by a community member label May 18, 2024
@tcl3 tcl3 deleted the libweb_output_element_htmlfor_attribute branch May 18, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants