LibWeb: Start adding infrastructure for an HTTP Cache #24406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
👀 pr-needs-review
alimpfard
reviewed
May 21, 2024
ADKaster
force-pushed
the
fetch-cache-start
branch
from
0fe093d
to
6d9b342
Compare
trflynn89
reviewed
May 22, 2024
Userland/Libraries/LibWeb/Fetch/Infrastructure/HTTP/Responses.cpp
Outdated
Show resolved
Hide resolved
Userland/Libraries/LibWeb/Fetch/Infrastructure/HTTP/Responses.cpp
Outdated
Show resolved
Hide resolved
Userland/Libraries/LibWeb/Fetch/Infrastructure/HTTP/Responses.cpp
Outdated
Show resolved
Hide resolved
Userland/Libraries/LibWeb/Fetch/Infrastructure/HTTP/Responses.cpp
Outdated
Show resolved
Hide resolved
ADKaster
force-pushed
the
fetch-cache-start
branch
from
e4f0b23
to
3ee69d1
Compare
|
cool cool, my latest push hit a 9 year old gcc CWG defect report that they haven't implemented yet. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66892 |
One step was added since we last visited this AO.
Defined in RFC9111 "HTTP Caching". Co-Authored-By: Andrew Kaster <akaster@serenityos.org>
Co-Authored-By: Andrew Kaster <akaster@serenityos.org>
ADKaster
force-pushed
the
fetch-cache-start
branch
from
3ee69d1
to
8e39246
Compare
trflynn89
approved these changes
May 23, 2024
github-actions
bot
removed
the
👀 pr-needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cache doesn't actually do anything yet, it just wastes a bit of memory.
Eventually this will need to be implemented in RequestServer and have a disk cache alongside the in-memory cache, but for now it's a few classes chilling in Fetch.
Progress towards #24185