Meta: Atomically download files at configure time, and validate with their SHA-256 hash #24407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
👀 pr-needs-review
trflynn89
force-pushed
the
cache_sha256
branch
3 times, most recently
from
14c7458
to
889735e
Compare
nico
approved these changes
May 22, 2024
This isn't always a "version file".
Download files to a temporary location, then only move the downloaded file to the real location once the download is complete. This prevents CMake from being confused about partially-downloaded files, e.g. if someone presses ctrl+c in the middle of a download. Note the GN build already behaves this way.
trflynn89
changed the title
github-actions
bot
removed
the
👀 pr-needs-review
|
The duplication of information is a bit sad between the build systems. is there room for some kind of JSON file or other metadata that holds the info of what we need to download? Could even be run through a pre-build script to download the files all at once, if desired. {
"files": [
{
"name": "CLDR",
"version": "44.1",
"sha256": "abcdef...."
"url": "unicode.org/blah/.zip"
}
]
} |
|
Is that more sad than duplicating the input files? And the set of downloaded files changes less frequently than the set of source files. Or do you mostly mean the duplicated sha? (That also changes less frequently than the source files though.) If you put this into a file, then now you have to read that file when it changes, etc, and it has a taste of metametabuildsystem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24401
This atomically downloads files to prevent CMake from being confused about partially-downloaded files, e.g. if someone presses ctrl+c in the middle of a download. And it adds SHA-256 verification for files that we currently have versioned downloads of.