LibWeb: Implement WorkerGlobalScope.importScripts()
#24423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcl3
commented
May 23, 2024
No behavior change.
The `api_base_url()` and `policy_container()` getters now get their respective objects from the global scope.
This method allows workers to synchronously import one or more scripts.
This fixes an issue where fetch requests to HTTP(s) addresses would fail inside workers.
tcl3
force-pushed
the
libweb_workerglobalscope_importscripts
branch
from
27e9c57
to
4d9f72c
Compare
tcl3
commented
May 27, 2024
github-actions
bot
added
the
👀 pr-needs-review
github-actions
bot
removed
the
👀 pr-needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method allows workers to synchronously import one or more scripts. It is used by all
*.worker.htmlWPT tests. Before this change all of these tests would time out, so this should yield a significant reduction in test timeouts.