LibWeb: Use stack to represent blit/sample corners commands state #24453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before: - sample corners id = 0 - sample corners id = 1 - sample corners id = 2 - blit corners id = 0 - blit corners id = 1 - blit corners id = 2 After: - sample corners id = 0 - sample corners id = 1 - sample corners id = 2 - blit corners id = 2 - blit corners id = 1 - blit corners id = 0
github-actions
bot
added
the
👀 pr-needs-review
|
Hello! One or more of the commit messages in this PR do not match the SerenityOS code submission policy, please check the |
Before, this check was needed to prevent crashing when attempting to allocate zero-size bitmap for sampled corners, which could have happened if a corner had 0 radius in one axis. Now, since SampleUnderCorners command is not emmited when radius is 0 in one axis, this check is no longer needed.
...instead of allocating separate BorderRadiusCornerClipper for each executed sample/blit commands pair. With this change a vector of BorderRadiusCornerClipper has far fewer items. For example on twitter profile page its size goes down from ~3000 to ~3 items.
kalenikaliaksandr
force-pushed
the
use-stack-for-sample-blit-corners
branch
from
8eb5e11
to
e5cc5d0
Compare
|
cc @MacDue |
|
Seems fine to me (though I've not been keeping up with changes in the |
github-actions
bot
removed
the
👀 pr-needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...instead of allocating separate BorderRadiusCornerClipper for each executed sample/blit commands pair.
With this change a vector of BorderRadiusCornerClipper has far fewer items. For example on twitter profile page its size goes down from ~3000 to ~3 items.