Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LibWasm: Use TRY macro when possible #24457

Merged
merged 1 commit into from
May 27, 2024
Merged

Conversation

dzfrias
Copy link
Contributor

@dzfrias dzfrias commented May 27, 2024

This removes a lot of the error handling boilerplate, and is more consistent with the rest of the codebase. Hopefully I'm not just being an idiot with this PR if there was a reason TRY isn't supposed to be used in these cases...

This removes a lot of the error handling boilerplate, and is more
consistent with the rest of the codebase.
@dzfrias dzfrias requested a review from alimpfard as a code owner May 27, 2024 01:11
@github-actions github-actions bot added the 👀 pr-needs-review PR needs review from a maintainer or community member label May 27, 2024
@alimpfard
Copy link
Member

TRY is fine, this code used to use Result<T, E> and was later converted to ErrorOr<T>; that's why almost none of the users use TRY - there was no TRY at the time :P

@alimpfard alimpfard merged commit e345d65 into SerenityOS:master May 27, 2024
12 checks passed
@github-actions github-actions bot removed the 👀 pr-needs-review PR needs review from a maintainer or community member label May 27, 2024
@dzfrias
Copy link
Contributor Author

dzfrias commented May 27, 2024

Ohh, I see. That makes sense!

@dzfrias dzfrias deleted the wasm-try branch May 27, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants