Kernel: Clean up duplicated code #24551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
👀 pr-needs-review
|
nit: "cleanup" is a noun, "clean up" is the verb. |
brody-qq
force-pushed
the
release-clean-pages-cleanup
branch
from
ca29480
to
7713ddf
Compare
brody-qq
changed the title
ok, I changed the titles for the PR and commit 👍 |
supercomputer7
approved these changes
Jun 9, 2024
The methods try_release_clean_pages() and release_all_clean_pages() in InodeVMObject are almost identical. This commit makes them both use the same code path.
brody-qq
force-pushed
the
release-clean-pages-cleanup
branch
from
7713ddf
to
5057d31
Compare
|
Thanks for the feedback I changed the commit title and message to be a bit more specific |
github-actions
bot
removed
the
👀 pr-needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 2 methods in InodeVMObject that are almost identical. This commit makes them both use the same code path.