LibWeb: Add support for text in the AffineCommandExecutorCPU
#24556
Conversation
github-actions
bot
added
the
👀 pr-needs-review
|
These are my last few commits a week or so ago. Probably won't continue with this experiment anymore (as transforms are likely not needed for the Serenity-only LibWeb, especially considering they won't work well with bitmap fonts)... but it was fun while it lasted :) Maybe this is still useful though? Otherwise, I can just close this. |
There was a problem hiding this comment.
I think merging this would be great! And who knows, maybe you'll continue it one day :)
A few test failures, otherwise looks great:
https://github.com/SerenityOS/serenity/actions/runs/9439428736/job/25997539818?pr=24556
Fail: /Users/runner/work/serenity/serenity/Tests/LibWeb/Ref/svg-text-effects.html
Fail: /Users/runner/work/serenity/serenity/Tests/LibWeb/Ref/canvas-text.html
Might need rebaselining or something? On https://github.com/SerenityOS/serenity/actions/runs/9439428736/job/25997539866?pr=24556 too (same tests).
These are only cached via the `append_glyph_path_to()` API, so uses of fonts that only care about bitmaps do not pay for this cache.
This applies an affine transform to a path in-place.
|
fddffdfdwfsf! |
github-actions
bot
removed
the
👀 pr-needs-review
Demo:
8mb.video-DSd-UCakbkty.mp4