Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/proc/net #422

Merged
merged 3 commits into from Aug 9, 2019
Merged

/proc/net #422

merged 3 commits into from Aug 9, 2019

Conversation

bugaevc
Copy link
Member

@bugaevc bugaevc commented Aug 9, 2019

  • Move /proc/netadapters and /proc/net_tcp to a new /proc/net directory, as /proc/net/adapters and /proc/net/tcp
  • Expose UDP socket info as /proc/net/udp

Would make sense to do next:

  • Expose local sockets info as /proc/net/local (or unix); it'd be great to expose interesting info like peer PID(s), but currently LocalSocket doesn't have enough functionality for this.
  • Display this all in ProcessManager — but how? UDP sockets have a strict subset of what TCP sockets have, so we could just combine both sources in one model and leave some fields empty. But local sockets have lots of additional fields, and adding more columns to the table is not an option since the existing ones don't fit in the default window size already. As a separate table, perhaps?

And move /proc/netadapters and /proc/net_tcp there. Now they're
/proc/net/adapters and /proc/net/tcp respectively, with more to come ^)
@awesomekling
Copy link
Member

These are some beautiful changes, Sergey! :)

@awesomekling
Copy link
Member

I'm happy you were able to make sense of ProcFS, it's certainly not the most extensible thing I've ever built..

@awesomekling awesomekling merged commit be48594 into SerenityOS:master Aug 9, 2019
@awesomekling
Copy link
Member

Agree about where to go next btw. We can add some interesting metadata like PID's to LocalSocket and I think separate tables in the GUI would make sense.

@bugaevc bugaevc deleted the proc-net branch August 9, 2019 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants