HexEditor+LibGUI: Initial version of HexEditor, LibGUI bug fix #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xeons
force-pushed
the
application-hex-editor
branch
2 times, most recently
from
a42a90e
to
3f1f18e
Compare
awesomekling
requested changes
Oct 12, 2019
| @@ -113,6 +113,11 @@ int GMenu::realize_menu() | |||
| request.menu.enabled = true; | |||
| request.menu.checkable = false; | |||
| request.menu.checked = false; | |||
|
|
|||
| // no shortcut on submenu, make sure this is cleared out | |||
There was a problem hiding this comment.
This looks like a useful fix, but please make it in a separate commit.
Libraries/LibGUI/GFilePicker.cpp
Outdated
| @@ -30,10 +30,10 @@ Optional<String> GFilePicker::get_open_filepath() | |||
|
|
|||
| Optional<String> GFilePicker::get_save_filepath(const String& title, const String& extension) | |||
| { | |||
| GFilePicker picker(Mode::Save, String::format("%s.%s", title.characters(), extension.characters())); | |||
| auto picker = GFilePicker::construct(Mode::Save, String::format("%s.%s", title.characters(), extension.characters())); | |||
There was a problem hiding this comment.
This is already fixed in LibGUI, please rebase on top of master. :)
Applications/HexEditor/GHexEditor.h
Outdated
| #include <LibDraw/TextAlignment.h> | ||
| #include <LibGUI/GScrollableWidget.h> | ||
|
|
||
| class GHexEditor : public GScrollableWidget { |
There was a problem hiding this comment.
The G prefix is generally used for classes in LibGUI. Since this class is outside LibGUI, you can just call it HexEditor or something like that instead.
I was encountering an entire system crash when the window server attempted to do something with the shortcut text on a submenu. This bug only seemed to appear when I had a lone submenu inside of a menu.
The very first release of the Hex Editor for Serenity.
xeons
force-pushed
the
application-hex-editor
branch
from
3f1f18e
to
e07e446
Compare
xeons
changed the title
|
Delightful 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial version of Hex Editor
I was encountering an entire system crash when the window server attempted to do something with the shortcut text on a submenu. This bug only seemed to appear when I had a lone submenu inside of a menu.
Also fixed a bug with the save dialog involving references.