Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up CircleCi #2

Merged
merged 4 commits into from
Oct 4, 2021
Merged

Conversation

ArchibaldBienetre
Copy link
Collaborator

@ArchibaldBienetre ArchibaldBienetre commented Sep 26, 2021

Before you merge this

(I would make this a Draft pull request, but this is a PRO feature that DonMischos setup does not support)
EDIT: It's not supported with my Pro account, either, it seems :/ https://docs.github.com/en/get-started/learning-about-github/githubs-products#github-team


Check with the configuration reference
in case of detailed questions:
https://circleci.com/docs/2.0/configuration-reference/

The CircleCI Java example is
needlessly verbose, imo
https://circleci.com/docs/2.0/language-java/

Working with CircleCI, it is recommended that you
install the CLI tool, so you can always run
circleci config validate
locally.
https://circleci.com/docs/2.0/local-cli/


✔️ This is working: See here: https://app.circleci.com/pipelines/github/ArchibaldBienetre/csv2tex?branch=set-up-circleci

* Gradle 7.1
* Java 8 - feel free to change that. Be aware that Gradle
does not support the latest, Java 17, yet.
@ArchibaldBienetre ArchibaldBienetre self-assigned this Sep 26, 2021
@ArchibaldBienetre ArchibaldBienetre changed the title Set up circleci Set up CircleCi Sep 26, 2021
Comment on lines 4 to 14
run_tests_java:
docker:
- image: cimg/openjdk:8.0.292
steps:
- checkout
- run: |
./gradlew clean test
- store_test_results:
path: test-results
- store_artifacts:
path: test-results
Copy link
Collaborator Author

@ArchibaldBienetre ArchibaldBienetre Sep 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you compare with the CircleCI Java example, we don't do any kind of caching of the installed Gradle wrapper, yet.

You will see this in the logs:

#!/bin/bash -eo pipefail
./gradlew clean test

Downloading https://services.gradle.org/distributions/gradle-7.1-bin.zip
..........10%...........20%...........30%..........40%...........50%...........60%..........70%...........80%...........90%...........100%

Welcome to Gradle 7.1!

https://app.circleci.com/pipelines/github/ArchibaldBienetre/csv2tex/2/workflows/ff40720c-47e1-44ef-9f8f-4e61ca37fbbb/jobs/2

This may make this build a bit slow.

We can add that later, if you want.

Check with the configuration reference
in case of detailed questions:
https://circleci.com/docs/2.0/configuration-reference/

The CircleCI Java example is
needlessly verbose, imo
https://circleci.com/docs/2.0/language-java/

Working with CircleCI, it is recommended that you
install the CLI tool, so you can always run
`circleci config validate`
locally.
https://circleci.com/docs/2.0/local-cli/
@ArchibaldBienetre ArchibaldBienetre mentioned this pull request Sep 26, 2021
4 tasks
@DonMischo DonMischo merged commit c22aeb3 into SergelsOrg:main Oct 4, 2021
@DonMischo DonMischo deleted the set-up-circleci branch October 4, 2021 04:50
This was referenced Oct 9, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants