-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compilation for clang/gcc and webassembly including ci pipeline #3
Merged
SergeyMakeev
merged 105 commits into
SergeyMakeev:master
from
AlpineMapsOrgDependencies:master
Jan 10, 2024
Merged
compilation for clang/gcc and webassembly including ci pipeline #3
SergeyMakeev
merged 105 commits into
SergeyMakeev:master
from
AlpineMapsOrgDependencies:master
Jan 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n times of x86-64)
…). todo: produce artefacts not gonna work in ci because: - the browser is anyway its own environment. - node couldn't start it, for whatever reason (no error message) - then i switched to my qml gui, which needs graphical output previous attempts: - couldn't open files, because wasi is very incomplete when compiling using emscripten. compiling with other toolchains also failed for various reasons. - e.g. couldn't use qrc due to some missing link time dependencies - porting to wasi is probably not impossible, but having it run in wasmtime or wasmer doesn't proove it working in the browser anyways. and i'm tired of it.
… for using too much memory
SergeyMakeev
approved these changes
Jan 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes #1 , in addition i fixed it up so it compiles to webassembly using emscripten. and i setup a ci pipeline to run tests on clang, gcc and msvc automatically. the ci pipeline also compiles and deploys a webassembly version of the tests (e..g https://alpinemapsorgdependencies.github.io/Goofy/), but doesn't run it. you have to open it manually and wait for the test to pass (the long test takes forever).