[Hotfix] Update Main.cs and ScriptCompiler.cs for MONO5 #3250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated for compatibility with MONO5. Checked with Mono 3.2.8 and Mono 5.10.0
corrected indents
Xeroxxx
changed the title
|
Nice Hotfix if it takes 2 weeks to review someone 5 lines of code. |
|
It's not just 5 lines of code, you changed the formatting of ScriptCompiler.cs which makes it hard to discern what has been changed in a side-by-side difference. In future, commit the changes, then commit file formatting changes separately. |
Voxpire
requested changes
Apr 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated for compatibility with MONO5.
Checked with Mono 3.2.8 and Mono 5.10.0
Changes in Main.cs
+ Checking for Mono Version #if Mono and Code is a double check right now
Changes in ScriptCompiler.cs
+ Changed file encoding (^M) to be inline with others
+ Changed lines 233 to 236 to resolve errors with Mono 5